6 Replies Last post: Jan 7, 2010 12:08 AM by Roman.Chernyatchik  
Chez Whorton Newbie 15 posts since
Oct 28, 2009
Currently Being Moderated

Dec 29, 2009 2:42 AM

Code review feature request

It would be very nice to have the ability to bring up a view that lets you select any particular git commit, then shows (a) the files in the commit, and (b) when you select one fo the files, the side-by-side full-file diff created by the commit. Essentially, this would be the same view you get when you do a git merge, select a file, and do command-D.

 

The point is to have the full-file context when reviewing code changes.

 

Thanks.

Dmitry Jemerov JetBrains 9,248 posts since
Aug 19, 2002
Currently Being Moderated
Dec 29, 2009 6:32 PM in response to: Chez Whorton
Re: Code review feature request

Hello Chez,

 

You can (almost) do this in the current version. From the File History panel,

you can select a commit and invoke the "Show All Affected Paths" action.

That gives you a list of all the files in the commit. In the list, you can

press Ctrl-D to get a diff dialog showing the changes in the commit. In the

diff dialog, you can also use the arrow buttons in the toolbar to move between

the files in the commit.

 

It would be very nice to have the ability to bring up a view that lets

you select any particular git commit, then shows (a) the files in the

commit, and (b) when you select one fo the files, the side-by-side

full-file diff created by the commit. Essentially, this would be the

same view you get when you do a git merge, select a file, and do

command-D.

 

The point is to have the full-file context when reviewing code

changes.

 

--

Dmitry Jemerov

Development Lead

JetBrains, Inc.

http://www.jetbrains.com/

"Develop with Pleasure!"

 

 

 

Oleg Shpynov JetBrains 555 posts since
Nov 6, 2007
Currently Being Moderated
Dec 30, 2009 12:37 AM in response to: Chez Whorton
Re: Code review feature request

Hi Chez,

Sounds good... can you tell me how to get to the File History panel?

Here are some screenshots to illustrate Dmitry's advice:

 

File History action button

file_history.png

This action will open File History tab within Version Control Tool window, click  Show All Affected Path action button

all_files.png

And voila - you can review all the available changes!

 

changes.png

ivarv Newbie 5 posts since
Dec 30, 2009
Currently Being Moderated
Dec 30, 2009 9:27 PM in response to: Oleg Shpynov
Re: Code review feature request

Thanks for the pointers, this is a useful task to make clear

 

I do have one request though, if when you provide such explanations for tips could you please provide keyboard shortcuts too ? One of the big draws of jetbrains products is the keyboard-centricity of your products.

Roman.Chernyatchik  JetBrains 754 posts since
Sep 18, 2007
Currently Being Moderated
Jan 7, 2010 12:08 AM in response to: ivarv
Re: Code review feature request

For VCS operations we recommend Version Contol | VCS Quick List.. It's shortcut differs in different keymaps but shortcut is visible in main menu near an action name. VCS Quick list is context sensitive and actions will be applied to 'current' file or all files in project. In popup you can also type number of menu item or it's name for quick access.

More Like This

  • Retrieving data ...