[#IDEA-11436] Allow testing JarFileSystem using custom filesystem

IDEA: Feedback

Allow testing JarFileSystem using custom filesystem

Created: 06 Feb 07 22:52 Updated: 25 Apr 07 14:33

Component/s:

Plugin Support. API

Build:	6,148
Severity:	Medium

Description

« Hide

Currently JarFileSystem will not recognize jar files in a custom filesystem. This makes testing harder and makes tests run slower because we can't use custom filesystems like DummyFS.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Vladislav Kaznacheev - 07 Feb 07 14:34

May I ask you to attach a sample test that should not fail?

[ Permlink | « Hide ]

Keith Lea - 02 Mar 07 21:10

Not quite, I'm asking for new API. I'd probably like to be able to create my own JarFileSystem which relies not on LocalFileSystem but a VirtualFileSystem of my choice. For example:

DummyFileSystem dummy = DummyFileSystem.getInstance();
dummy.createRoot("x").createChildData(null, "y.jar");
JarFileSystem jarfs = JarFileSystem.getTestingInstance(dummy);
VirtualFile jarRootFolder = jarfs.findFileByPath("x/y.jar!/")

Of course this would depend on ~~IDEA-11777~~ being implemented, and of course I would need to fill in the jar data in the dummy FS myself.

[ Permlink | « Hide ]

Vladislav Kaznacheev - 20 Mar 07 19:20

DummyFileSystem is internal class not intended for general use, and currently there are no plans to make it more complete

[ Permlink | « Hide ]

Keith Lea - 19 Apr 07 00:37

This is not specific to DummyFileSystem. If I create my own custom filesystem it still doesn't work.

Please re-open this issue. I'm asking to be able to inject a VirtualFileSystem into JarFileSystem for testing. I think this is a reasonable request for a feature that would be useful to other developers as well.

[ Permlink | « Hide ]

Vladislav Kaznacheev - 25 Apr 07 14:33

This is likely to be part of file system rewrite planned for Selena