[#IDEA-14542] Find Bar: Options for Incremental Search

IDEA: Feedback

Find Bar: Options for Incremental Search

Created: 27 Aug 07 13:20 Updated: 31 Jan 08 18:25

Component/s:

Find, Replace, Find Usages

Build:	7,241
Severity:	Medium

Description

« Hide

When invoking the Incremental Search action, the option "Whole words only" is quite the opposite than what one would expect from the action. Therefore it should not share its state with the other search action(s) and probably shouldn't even be shown at all for this action.

The same also applies to the setting for case-sensitivity: The "old" incremental search action was quite smart about finding this out on its own. I think this shouldn't be changed. At least, like the whole words setting, it should not be shared with the other actions.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Sascha Weinreuter - 02 Oct 07 01:05

Max, what do you think? I really prefer the new UI for the incremental search, but the shared behavior with the normal find is really annoying.

[ Permlink | « Hide ]

Maxim Shafirov - 03 Oct 07 00:18

Well, "whole words" option (as well as "case sensitive") doesn't seem to be shared with "Find in Files" anymore. What other search action this can clash with?
As to automatic case sensitivity of old incremental search that drove me nuts many times, like it doesn't match PsiFile against psiFile pattern just because I used to Ctrl+N style patterns and intuitively camelizing where new word starts.
As a bonus, new implementation has Ctrl+Space completion in the search field, that truly supports camel case patterns.

[ Permlink | « Hide ]

Sascha Weinreuter - 03 Oct 07 01:44

It's not about sharing the options with "Find in Files", but between the Find Bars that are shown when pressing ctrl-f (for regular find) and alt-f3 (for incremental search). So basically, there should be two different actions that both show the Find Bar, but use different find-models (the one for alt-f3 doesn't even need a "Whole words only" checkbox). On the other hand, people could consider this as inconsistent and confusing. I'm not really sure any more, it's probably a "getting used to" kind of thing... :/

And you're right, I also had some kind of love/hate relationship with that "smart" case sensitivity. Unless someone else complains, I think it's fine as it is now because it can be easily toggled and is then instantly applied.

[ Permlink | « Hide ]

Sascha Weinreuter - 31 Jan 08 18:25

Hmm, since both the "old" incremental search and find actions are available again, I think this has become more or less obsolete. And btw, after comparing "old" vs." "new" for some time now on different machines (work/home), I stopped using the old "incremental search" at all.