[#IDEABKL-3615] Ctrl-Shift-Space on method.accept(new PsiRecursiveElementVisitor shows override dialog

IDEA: Backlog

Ctrl-Shift-Space on method.accept(new PsiRecursiveElementVisitor shows override dialog

Created: 09 May 06 08:07 Updated: 11 May 06 18:36

Component/s:

Editor. Code Completion

Affects Version/s:

None

Fix Version/s:

None

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

Build:	5,261
Severity:	Medium

Description

« Hide

PsiMethod method = ... ;
method.accept(new PsiRecursiveElementVisitor<Ctrl-Shift-Space>

brings up the 'Select Methods to Override' dialog. This does not seem right.

If there is a reason for this dialog that I have not spotted, the dialog should at least have a button 'Select None', in my opinion.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Eugene Vigdorchik - 11 May 06 18:05

Completion presumes that in case there are no methods to implement, then the user will in 95% of the cases want to override some methods from the base class.

[ Permlink | « Hide ]

Etienne Studer - 11 May 06 18:36

I see. In that case, what I find a bit confusing is that it only shows the two methods from the direct super class (PsiRecursiveElementVisitor). Wouldn't it make sense to show all methods from all super classes (as it is done when triggering a Ctrl-O)?