History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: IDEABKL-3798
Type: Usability Problem Usability Problem
Status: Open Open
Priority: Normal Normal
Assignee: Dmitry Jemerov
Reporter: Sascha Weinreuter
Votes: 0
Watchers: 0
Available Workflow Actions

Mark as Stalled
Operations

If you were logged in you would be able to see more operations.
IDEA: Backlog

Component-properties are shown as modified (bold) even when they're set to their default value

Created: 07 Feb 06 23:30   Updated: 31 Oct 06 17:36
Component/s: GUI Designer
Affects Version/s: None
Fix Version/s: None

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
File Attachments: None
Image Attachments:

1. screenshot-1.jpg
(8 kb)

Build: 5,131


 Description  « Hide
E.g. clicking the "enabled" property once to toggle it off makes the "enabled" appear in bold, but after switching it back on, it's still bold. I also noticed that such properties are written into the .form file, which shouldn't happen as well because this causes unnecessary changes in the VCS.

 All   Comments   Work Log   Change History      Sort Order:
Sascha Weinreuter - 07 Feb 06 23:37
another example

Dmitry Jemerov - 08 Feb 06 13:21
I consider this a feature, not a bug. Setting enabled=true for a component explicitly is not the same as keeping enabled to whatever value was set by the component constructor (which can in some cases be determined dynamically).

This is subject to discussion, though - maybe in some cases (boolean properties, component properties with value=null) it makes sense to treat explicit setting of default value as resetting the value.


Sascha Weinreuter - 08 Feb 06 13:47
Aha, so would "restore default value" make the property display in non-bold text again? Would this also remove it from the .form file?

I basically agree with you that there is a difference between a default value and an explicitly set value, but it does look quite odd in the UI, especially in the case I pictured in the screenshot, don't you agree?


Dmitry Jemerov - 08 Feb 06 14:19
Yes, "restore default value" removes the property from the list of modified properties, so it isn't shown as bold and isn't saved in the form.

Any suggestions to make it less odd are welcome.


Sascha Weinreuter - 09 Feb 06 00:07
I see, that stuff is so new and hot that I did not think about this possibility at first

A partial solution for the odd look might be not to highlight the property value, but just its name. And you could add a tooltip that tells the user about the "restore default value" if the currently set value is the same as the default.

By the way I think the highlighting should be done with blue text like it's done with the inspections.