[#IDEABKL-4409] "Close battle" Duplicate locations

IDEA: Backlog

"Close battle" Duplicate locations

Created: 15 Dec 05 13:38 Updated: 09 Nov 06 20:27

Component/s:

Code Analysis. Inspection

Affects Version/s:

None

Fix Version/s:

None

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

Build:	4,000
Severity:	High

Description

« Hide

It would be very good if for next code:
if (a.getB() != null && a.getB().longValue()>0) {
List aa = getC(a.getB, e);

a.getB was detected like duplication and warning will be available, it may be as light as possible version of code duplication detector, in enclosing 2 or 3 lines. I think it may be easy added.

Bas? David? Do you hear this?

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Dmitry Kashin - 15 Dec 05 13:46

It would be very good if for next code:

"Smell source"

if (a.getB() != null && a.getB().longValue()>0) {
    List aa = getC(a.getB, e);

a.getB was detected like duplication and warning will be available, it may be as light as possible version of code duplication detector, in enclosing 2 or 3 lines. I think it may be easy added.

"Markup rulezz"

Bas? David? Do you hear this?

[ Permlink | « Hide ]

Maxim Shafirov - 23 Dec 05 02:29

This is not as easy as it seems. To make a suggestion like this one has to ensure getB() doesn't have a side effect so replacing 3 calls with one won't change the semantics.