|
|
|
[
Permlink
| « Hide
]
Dmitry Jemerov - 02 May 07 14:50
The branch to which modified files are switched is shown in the Changes view and in the checkin dialog. I believe that presenting this information as text is clearer than adding yet another color to the multitude of file status colors already in the product.
I don't agree. You could have made the same argument about color coding the switched tab.
For the most part, the tabs are generally black for unchanged, blue for modified and turquoise for switched. The benefit would be to prevent accidental checkins to the head instead of the branch (like happened to me when I opened this issue) The use-case was - a developer branched several classes in a module that needed modification. I reviewed all of the changes, selected all of the blue tabs, and checked them in. There are many ways to break the build by checking in wrong files. The proper way to avoid that is to review the list of selected files before checking them in.
I'm all in favor of features that really help prevent checking in wrong files, but I'm afraid that adding three more subtle shades of file status colors (note that you'll need colors for "switched modified", "switched added" and "switched deleted") will be more confusing than helpful. Sir, this is an easy one - it would just require adding one more shade, not 3.
There are many ways to break a check in, but those should not be aided by IntelliJ, IntelliJ has always been great about helping me prevent such errors. That's why we pay for IntelliJ when we can get Eclipse for free. Everyone who is using version control knows very well what the color codes are about. IntelliJ has always been about "developing with pleasure" and helping developers do their work. I have an idea for a compromise - why not provide the "switched updated" color as an option in the Colors and Fonts settings, but set it by default to the same color as the "non-switched" updated. That way the people who find the change confusing will have it your way, and people like me who consider it a major nuisance would have the ability to change it. Please? This is really important! I don't think that such a compromise is a good idea because 99% of the users (even those who might need that capability) will never discover it.
I think that an explicit, modal warning dialog box shown when you try to commit files to different branches at the same time (non-switched and switched, or switched to different branches) will be a much more helpful and less confusing way to avoid this kind of problems. (The dialog should of course have a "Don't show this again" option if such checkins are normal in some people's workflow). Your suggestion is good for the use-case I described, but it will not work in the case where I am looking at 6 blue file editors and I just check them in one by one.
I have another suggestion - instead of color coding, would it be possible to use the same current coding as before, except add an icon in the tab (perhaps a little black circle next to the file name) indicating that it is a changed file. You could also display that icon in the project view. This would help for identifying changed files without any new color coding. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||