History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: IDEADEV-11768
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Michael Gerasimov
Reporter: Stephen Friedrich
Votes: 1
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
IDEA: Development

SourceSafe: Change markes are gone immediately when I save

Created: 08 Nov 06 12:09   Updated: 26 Feb 07 05:23
Component/s: Version Control Integration. VSS
Fix Version/s: Demetra 6.0.3

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown
Issue Links:
Depend
 
This issue is required for:
IDEADEV-11769 VSS: the list of changed files should... Normal Resolved

Build: 6,068
Fixed in build: 6,110
Severity: Medium


 Description  « Hide
Idea shows my changes in the left gutter fine.
I press ctrl-s.
The change markers immediately vanish from the gutter.
Also the color of the file in tab and package explorer becomes black.

 All   Comments   Work Log   Change History      Sort Order:
Stephen Friedrich - 10 Nov 06 12:05
still a problem in 6094

Irina Petrovskaya - 10 Nov 06 12:41
repeatable in 6593 also. The file status is updated after refresh in changes view / refresh file status

Michael Gerasimov - 10 Nov 06 15:44
Problem appears when local paths:
1. Long "enough"
2. Contain blanks in folder names.

In this case, in output stream the pattern
"Diffing: <$VSS Repository path>
Against: <local path>" is broken.

I need to collect more information on what breakage patterns are also possible and correct them all in one change (in order to be tested thoroughly)


Irina Petrovskaya - 10 Nov 06 17:02
the same problem - with € symbol in file name

Stephen Friedrich - 16 Nov 06 13:01
Any chance for "Fix Version/s: Next Version, Demetra Minor Release" ?

There have been lots of VSS bug fixes for 6.0.2 already, but this one is really nasty and kind of defeats all those other fixes.

It does not only happen when I save explicitly (which I do rarely), but also for examlpe if I change a unit test (file is blue), then run it it (file gets black).
It feels like it also occurs in other situations, but I have not been able to verify that.

I keep doing refresh and refresh again in the changes view.


Stephen Friedrich - 24 Nov 06 17:34
Still a problem for me in 61111, even though the link from the 6.0.3 EAP announcement forum thread says it's fixed.

What kind of info can I send to help you fix this bug?


Stephen Friedrich - 24 Nov 06 17:57
BTW, I just noticed a couple of these exceptions in the Idea console window:
java.util.ConcurrentModificationException
        at java.util.HashMap$HashIterator.nextEntry(HashMap.java:841)
        at java.util.HashMap$KeyIterator.next(HashMap.java:877)
        at com.intellij.vssSupport.VssChangeProvider.addRemovedFiles(VssChangeProvider.java:676)
        at com.intellij.vssSupport.VssChangeProvider.getChanges(VssChangeProvider.java:109)
        at com.intellij.openapi.vcs.changes.ChangeListManagerImpl.a(ChangeListManagerImpl.java:276)
        at com.intellij.openapi.vcs.changes.ChangeListManagerImpl.access$700(ChangeListManagerImpl.java:218)
        at com.intellij.openapi.vcs.changes.ChangeListManagerImpl$4.run(ChangeListManagerImpl.java:4)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:417)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:269)
        at java.util.concurrent.FutureTask.run(FutureTask.java:123)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:65)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:168)
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
        at java.lang.Thread.run(Thread.java:595)
[1360928]  ERROR - .changes.ChangeListManagerImpl -
[1361663]  ERROR - .changes.ChangeListManagerImpl - IntelliJ IDEA 6.0.3 Beta  Build #6111
[1361663]  ERROR - .changes.ChangeListManagerImpl - JDK: 1.5.0_09
[1361663]  ERROR - .changes.ChangeListManagerImpl - VM: Java HotSpot(TM) Client VM
[1361663]  ERROR - .changes.ChangeListManagerImpl - Vendor: Sun Microsystems Inc.
[1361678]  ERROR - .changes.ChangeListManagerImpl - OS: Windows XP
[1361678]  ERROR - .changes.ChangeListManagerImpl - Last Action: SaveAll

I don't get this exception every time, but quite often.


Michael Gerasimov - 27 Nov 06 11:55
I had no ability to integrate all the changes into 6.03 branch, and will finish with that on this week.
The stacktrace above is not an exception but rather the trace for debugging performance problems - sometimes IDEA calls complete refresh on startup twice which is unacceptable.

Concerning the bug per se I've managed to fix it by completely rewriting the diffing method.


Stephen Friedrich - 27 Nov 06 12:50
Thanks a lot for your work and dedication. I know from experience the work involved to do fixes on multiple branches.

Isaac Wu - 26 Feb 07 05:23
This issue is put in 6.0.4 release notes as a fixed bug. But it seems I can still see it.
The build is 6.0.4 release build that I downloaded from jetbrains site(build6148).

What about others? Could you reproduce this bug. It's really annoying