|
|
|
[
Permlink
| « Hide
]
Maxim Mossienko - 07 Feb 06 15:07
Second problem is not observed in 5.1
Thanks for the prompt resolution to this problem. Is there any way for me to get build 4157 with the fix?
Also, I wanted to clarify the second issue. The problem is that all variables are being interpreted as AT_END, so even if you return VariableInfo with AT_BEGIN or AT_NESTED, IntelliJ won't recognize the variable for auto-completion until after the end of the tag. Thus, something like a for loop wouldn't work. e.g.: <%-- assuming loopVar had returned VariableInfo with AT_NESTED specified --%> <%-- in IntelliJ 5.0.2, the loopVar only was accessible for auto-completion at this point, which is clearly invalid since the variable is actually only available within the body of the g:forEach tag --%> Does that clarify the issue? If it is fixed in 5.1, then that would be wonderful. There's no way for me to tell on build 4155 since it has the general auto-completion bug, but I can confirm that it is fixed if I can get my hands on 4157. Thanks for your help, Brian Hi,
In two weeks we will release 5.1.1 (most likely without eap) that will contain the fix. I tried your custom tag giving it custom parameter and it completes inside as expected (so if the problem replays then please file another issue). There is one other related issue in 5.0.2 that I forgot to mention. Auto-completion doesn't work correctly when a property is parameterized with Java 1.5 generics. I have uploaded a new sample.zip showing the problem. See the generics.jsp file. Notice that typedMapEntry properly has its properties (key/value) auto-completed. The issue/bug here is that mapEntry does not have its properties properly auto-completed, despite the fact that it is parameterized to <T extends Map.Entry>. Map.Entry isn't the best example, but I chose it since it is simple and has a key and value property accessible via getters.
It would be GREAT if you could address this issue in the upcoming 5.1.1 release. Please let me know if you'd like me to create separate bug issues for these types of problems. I figured that since it is pretty closely related to this issue that I could piggy-back. Additionally, it would be nice if IntelliJ could detect the proper class based on its parameterized type.
e.g. class Foo { class Bar extends Foo { class BarBean extends FooBean<Bar> { Then, in JSP, do something like: ${barBean.foo.y} where "barBean" is an instance of BarBean. Note that in this case, IntelliJ would detect that the "T" parameter in FooBean is of type Bar, and thus allows auto-completion of the "y" property of Bar. Does that make sense? Let me know if you'd like a more explicit example (with sample project/code). Thank you for the feedback.
Please, open another issue(s) for the bugs you attached. They will be fixed in Demetra release (only serious regression issues will be considered for 5.1.1 ). Thanks for the heads up, Maxim. I have created a new issue for the additional problems I described above:
IDEA-6695 FYI, I tested this on the latest 5.1.1 EAP (4171), and the problem is fixed. Thanks!
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||