[#IDEADEV-4892] Although the HTML-inspection "Check Image Size" is selected, random width or height attributes can be given without a warning

IDEA: Development

Although the HTML-inspection "Check Image Size" is selected, random width or height attributes can be given without a warning

Created: 01 Mar 06 13:26 Updated: 01 Mar 06 17:31

Component/s:

HTML.Editing

Fix Version/s:

5.1.1

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

File Attachments:

None

Image Attachments:

1. main-window_small.gif
(11 kb)

Build:	4,155
Fixed in build:	4,161
Severity:	High

Description

« Hide

Ctrl-clicking at the image's src-path opens the image in a separate tab, so the Images plug-in is installed correctly. But I can enter any number in the width or height attribute without getting a warning.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Maxim Mossienko - 01 Mar 06 14:36

We are not decoding image ourself, rather using ImageIO, if it fails for particular image then no check is performed. Could you, please, attach the image file?

[ Permlink | « Hide ]

Maxim Mossienko - 01 Mar 06 15:48

Thank you, does the 'img' element used outside root element?

[ Permlink | « Hide ]

Maxim Mossienko - 01 Mar 06 16:24

Please, check that image height/size problem is detected when img is under root tag.

[ Permlink | « Hide ]

Thomas Singer - 01 Mar 06 16:49

Hmm, do I understand you right:

In 4155 it does only work, when the jsp file is a valid html file and not, as in my case, where the outer tags (html, body, ...) are generated by scriptlets. You fixed that, so the upcoming 4161 version also support that in my case?

[ Permlink | « Hide ]

Maxim Mossienko - 01 Mar 06 17:06

To be sure that your problem is fixed please put img tag to the beginning of the jsp file, the width/height problem should be detected.
The problem is fixed in 5.1.1

[ Permlink | « Hide ]

Thomas Singer - 01 Mar 06 17:30

Yes, when I copy the <img src="..."> line to the top of the line, different widths and heights are detected.

[ Permlink | « Hide ]

Thomas Singer - 01 Mar 06 17:31

Of course, I meant "top of the file".