[#IDEADEV-5899] "never queried" inspection ignoring implicit toString()

IDEA: Development

Created: 03 May 06 01:55 Updated: 09 May 06 17:47

Component/s:

Code Analysis. Inspection

Fix Version/s:

Demetra 5281

Original Estimate:	Unknown	Remaining Estimate:	Unknown	Time Spent:	Unknown
Environment:	JDK 1.5.0_06 Win XP

Description

« Hide

The inspection "Contents of collection are updated, but never queried" matches incorrectly on:

private static String foo() {
List bar = new ArrayList();
bar.add("okay");
return "not " + bar;
}

This inspection works if the toString() is explicit, e.g., return "not " + bar.toString();

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

The inspection is wrong in the second case,. isn't it?

[ Permlink | « Hide ]

I think it's correct in recognizing bar.toString() as a query on the contents of bar, but incorrect in not recognizing "" + bar as the same query.