[#IDEADEV-9977] DOM-Model: @NameValue references coming from another file (MergingFileDescription) not used in getVariants()

IDEA: Development

DOM-Model: @NameValue references coming from another file (MergingFileDescription) not used in getVariants()

Created: 16 Aug 06 13:24 Updated: 26 Sep 06 19:26

Component/s:

Editor. Code Completion

Fix Version/s:

Demetra 6.0.2

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

Issue Links:

Duplicate

This issue is duplicated by:
	~~IDEA-8852~~ DOM-Model: @NameValue references comi...

Build:	5,994
Fixed in build:	5,743
Severity:	High

Description

« Hide

resolution + navigation works though

http://www.intellij.net/forums/thread.jspa?threadID=244883&tstart=0

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Yann Cébron - 22 Sep 06 11:13

will this be fixed for Demetra? this makes DOM-Model not very useful for everything besides standalone single XML files

[ Permlink | « Hide ]

Peter Gromov - 26 Sep 06 13:21

Seems that I've understood the problem. IntelliJ IDEA gives you the file copy for the completion. What if you try to use PsiFile#getOriginalFile() in your getFilesToMerge() implementation whenever possible as a workaround?

[ Permlink | « Hide ]

Yann Cébron - 26 Sep 06 14:01

then everything breaks

[ Permlink | « Hide ]

Peter Gromov - 26 Sep 06 14:04

How?

[ Permlink | « Hide ]

Yann Cébron - 26 Sep 06 14:49

then even reference/completion within the same file is broken (because xmlFile.getOriginalFile() returns null?)

[ Permlink | « Hide ]

Peter Gromov - 26 Sep 06 14:55

If it returns null, use the file you have, otherwise change it:
PsiFile originalFile = file.getOriginalFile();
if (originalFile != null) file = originalFile;

I understand that this is not very nice, I'll do the same thing in MergingFileDescription in 6.0.1, if, of course, it proves to be the problem source

[ Permlink | « Hide ]

Yann Cébron - 26 Sep 06 15:09

still "no suggestions" for completion

[ Permlink | « Hide ]

Peter Gromov - 26 Sep 06 15:20

Strange. As usual, everything works for me. The problem still must be connected with original/non-original files. Is the getFilesToMerge() called at the completion? Is there a right physical DomElement passed?

[ Permlink | « Hide ]

Yann Cébron - 26 Sep 06 15:26

yes, getFilesToMerge() is called at completion and I get DomElements passed in

I will mail you the sources in private