[#RSRP-15901] Optimize Using misbehaves with preprocessor directives

ReSharper

Optimize Using misbehaves with preprocessor directives

Created: 05 Aug 06 22:09 Updated: 11 Jun 07 15:11

Component/s:

Code Cleanup

Fix Version/s:

Future Versions

Security Level:

Everybody (All jira users)

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

Issue Links:

Duplicate

This issue is duplicated by:
	~~RSRP-42651~~ Namespaces Optimzed - Into Conditiona...
	~~RSRP-28483~~ "Optimize usings" works incorrectly w...
	~~RSRP-24822~~ Optimize usings moves using block out...
	~~RSRP-32835~~ Incorrect reformat of using statements
	~~RSRP-32088~~ 'Remove redundant qualifier' removes ...

Build:	215
Old URL:	http://www.intellij.net/tracker/resharper/viewSCR?publicId=15901

Description

« Hide

If a using directive was inside a branch of a preprocessor statement #if,
it gets moved outside of it. This may result in broken compilation with another combination of preprocessor directives. Either respect placement of using directives inside preprocessor statements, or simply issue a warning during optimization that will draw user attention to this problem.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

John W Saunders III - 11 Jun 07 15:11

If you're not going to fix this soon, you should consider something to mitigate the problem - like a warning or something. Maybe a simple warning about having using declarations within conditionals. It's the kind of thing I'm going to have to do with regular expressions otherwise - to find other places in the code that will be affected if I do a mass "Reformat Code".