[#RSRP-28304] Push members does insert wrong "base." qualifiers

ReSharper

Push members does insert wrong "base." qualifiers

Created: 29 Aug 06 16:09 Updated: 24 Oct 06 18:12

Component/s:

Refactorings

Fix Version/s:

2.0.2

Security Level:

Everybody (All jira users)

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

Fixed in build:

264

Description

« Hide

abstract class Base
{
  protected abstract void Foo();
  
  public void Bar()
  {
    Foo();
  }
}

class Derived : Base
{
  protected override void Foo()
  {    
  }
}

Push 'Bar' down to the Derived. Result is:

abstract class Base
{
  protected abstract void Foo();
}

class Derived : Base
{
  protected override void Foo()
  {    
  }

  public void Bar()
  {
    base.Foo();
  }
}

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Andrey Simanovsky - 19 Sep 06 14:26

The following test checks the case:
PushMembersDownTest.testBug28304

[ Permlink | « Hide ]

Andrey Simanovsky - 19 Sep 06 14:27

Looks like it is dangerous to fix it in 2.0.2.

[ Permlink | « Hide ]

Valentin Kipiatkov - 21 Sep 06 18:00

But it's a really serious issue. It may change code semantics!