History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: RSRP-37280
Type: Usability Problem Usability Problem
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Andrey Simanovsky
Reporter: Serge Baltic
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
ReSharper

"Possible Unintended Reference Comparison" Error: Bad Set of QFix/CAs

Created: 16 Mar 07 22:24   Updated: 09 Jun 07 18:20
Component/s: Context actions, Quick Fixes
Fix Version/s: 3.0
Security Level: Everybody (All jira users)

Original Estimate: Unknown Remaining Estimate: Unknown Time Spent: Unknown

Fixed in build: 456


 Description  « Hide
The error occurs on expressions like
if(this == obj)

There are:

  • QFix: cast obj to type of this and still use operator ==.
  • CA: use Equals.

Missing:

  • Use ReferenceEquals.

Also the problem is that one is a QFix and another is a CA, while it's hard to tell why one is more important than another.

The new ReferenceEquals QFix/CA should have highest priority of all (go the first in the list, possibly thus a QFix), because it does not change the code logic and won't lead to StackOveflowException in case of a recursive ==Equals call.



 All   Comments   Work Log   Change History      Sort Order:
There are no comments yet on this issue.