[#RSRP-59763] Invert if to reduce nesting context action is NOT reducing nesting in some cases

ReSharper

Invert if to reduce nesting context action is NOT reducing nesting in some cases

Created: 28 Feb 08 20:59 Updated: 06 May 08 18:56

Component/s:

Generate Action

Fix Version/s:

4.0

Security Level:

Everybody (All jira users)

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

Build:

740

Description

« Hide

Given the following:

private static void MyMethod(MyClass1 searcher, MyClass2 oldItem)
        {
            if (oldItem != null && searcher != null)
            {
                try
                {
                    // Some operation
                }
                catch (Exception e)
                {
                    // Some logging code
                }
            }
        }

When I do the suggested invert if to remove nesting, it generates the following:

if (oldItem == null || searcher == null)
            {
            }
            else
            {
                try
                {
                    // My operation
                }
                catch (Exception e)
                {
                    // My logging
                }
            }

when it should generate:

if (oldItem == null || searcher == null)
                 return;
            try
            {
                 // My operation
            }
           catch (Exception e)
            {
                 // My logging
            }

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Matt Eland - 28 Feb 08 20:59

My bad. Misnamed the issue. Should be... is NOT reducing nesting in some cases