[#RUBY-1121] Inconsistent javascript formatting in rhtml vs html

Ruby

Inconsistent javascript formatting in rhtml vs html

Created: 31 Oct 07 20:27 Updated: 19 Nov 07 16:46

Component/s:

RHTML

Fix Version/s:

1.0

Original Estimate:

Unknown

Remaining Estimate:

Unknown

Time Spent:

Unknown

Description

« Hide

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
    <meta http-equiv="content-type" content="text/html;charset=UTF-8"/>
    <title>Some Title: TODO</title>
    <%= javascript_include_tag 'reflection', 'niftycube' %>
    <link rel="stylesheet" type="text/css" href="http://yui.yahooapis.com/2.3.1/build/reset-fonts-grids/reset-fonts-grids.css">
    <link rel="stylesheet" type="text/css" href="http://yui.yahooapis.com/2.3.1/build/base/base-min.css">
    <%= stylesheet_link_tag 'niftyCorners', 'main' %>

    <script type="text/javascript" src="http://yui.yahooapis.com/2.3.1/build/yahoo/yahoo-min.js"></script>
    <script type="text/javascript" src="http://yui.yahooapis.com/2.3.1/build/event/event-min.js"></script>
    <script src="http://yui.yahooapis.com/2.3.1/build/dom/dom-min.js"></script>
    <%= javascript_include_tag 'ext-yui-adapter', 'ext-all' %>

    <script type="text/javascript">
        Ext.onReady(function(){
                Ext.state.Manager.setProvider(new Ext.state.CookieProvider());
                var viewport = new Ext.Viewport({
                        layout:'border',
                        items:[
                                {
                                        region:'north',
                                        contentEl: 'header'
                                        },
                                {
                                        region: 'center',
                                        contentEl: 'content',
                                        autoScroll:true
                                        },
                                ,
                                {
                                        region:'south',
                                        contentEl: 'footer'
                                        }
                                ]
                        });
                });
    </script>

</head>
<body>

<div id="header">
    <h1>JetBrains Library</h1>
</div>

<div id="content">
    <% if flash[:notice] -%>
        <p style="color: green"><%= flash[:notice] %></p>
    <% end -%>

    <% if flash[:error] -%>
        <p style="color: red"><%= flash[:error] %></p>
    <% end -%>

    <%= yield %>
</div>

<!--<div id="sidebar">-->
<!--Sidebar-->
<!--</div>-->

<div id="footer" class="copyright">
    Copyright &copy; JetBrains, Inc. 2007
</div>
</body>
</html>

Description

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
    <meta http-equiv="content-type" content="text/html;charset=UTF-8"/>
    <title>Some Title: TODO</title>
    <%= javascript_include_tag 'reflection', 'niftycube' %>
    <link rel="stylesheet" type="text/css" href="http://yui.yahooapis.com/2.3.1/build/reset-fonts-grids/reset-fonts-grids.css">
    <link rel="stylesheet" type="text/css" href="http://yui.yahooapis.com/2.3.1/build/base/base-min.css">
    <%= stylesheet_link_tag 'niftyCorners', 'main' %>

    <script type="text/javascript" src="http://yui.yahooapis.com/2.3.1/build/yahoo/yahoo-min.js"></script>
    <script type="text/javascript" src="http://yui.yahooapis.com/2.3.1/build/event/event-min.js"></script>
    <script src="http://yui.yahooapis.com/2.3.1/build/dom/dom-min.js"></script>
    <%= javascript_include_tag 'ext-yui-adapter', 'ext-all' %>

    <script type="text/javascript">
        Ext.onReady(function(){
                Ext.state.Manager.setProvider(new Ext.state.CookieProvider());
                var viewport = new Ext.Viewport({
                        layout:'border',
                        items:[
                                {
                                        region:'north',
                                        contentEl: 'header'
                                        },
                                {
                                        region: 'center',
                                        contentEl: 'content',
                                        autoScroll:true
                                        },
                                ,
                                {
                                        region:'south',
                                        contentEl: 'footer'
                                        }
                                ]
                        });
                });
    </script>

</head>
<body>

<div id="header">
    <h1>JetBrains Library</h1>
</div>

<div id="content">
    <% if flash[:notice] -%>
        <p style="color: green"><%= flash[:notice] %></p>
    <% end -%>

    <% if flash[:error] -%>
        <p style="color: red"><%= flash[:error] %></p>
    <% end -%>

    <%= yield %>
</div>

<!--<div id="sidebar">-->
<!--Sidebar-->
<!--</div>-->

<div id="footer" class="copyright">
    Copyright &copy; JetBrains, Inc. 2007
</div>
</body>
</html>

Show »

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Roman Chernyatchik - 02 Nov 07 17:49

also see ~~RUBY-1132~~

[ Permlink | « Hide ]

Roman Chernyatchik - 03 Nov 07 20:57

suggested fix was implemented, rev.12117

[ Permlink | « Hide ]

Taras Tielkes - 07 Nov 07 02:41

Out of curiosity, what's the suggested fix?

If I remember correctly, formatting of injected language in not yet implemented in Selena (~~IDEADEV-11212~~).

[ Permlink | « Hide ]

Roman Chernyatchik - 07 Nov 07 17:22

It means that if Javascript plugin is enabled then code between tags <script type="text/javascript">...</script> will be formatted by JavaScript formatter as JavaScript code.

[ Permlink | « Hide ]

Roman Chernyatchik - 19 Nov 07 16:46

done, rev. 12537